lkml.org 
[lkml]   [2017]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code'
On Fri, Feb 10, 2017 at 08:11:18AM -0800, James Bottomley wrote:
> On Fri, 2017-02-10 at 10:52 +0200, Jarkko Sakkinen wrote:
> > On Wed, Feb 08, 2017 at 01:07:08PM +0200, Jarkko Sakkinen wrote:
> > > + rc = tpm2_load_context(chip, space->session_buf,
> > > + &offset, &handle);
> > > + if (rc == -ENOENT) {
> > > + /* load failed, just forget session */
> > > + space->session_tbl[i] = 0;
> >
> > This is my only concern in this commit. Should we also in this case
> > just flush the space or not?
>
> I elected not to. If the handle is flushed by an external resource
> manager, we get this event. If the RM and the app agreed to release
> the session handle, then flushing the space would be overkill because
> it would destroy the client session, so simply removing the handle
> works. If the client tries to use the session again, it gets an error
> and if it doesn't everything just works, which seems to be optimal.
>
> James

Makes sense. Just wanted the check the logic you had in this decision.

/Jarkko

\
 
 \ /
  Last update: 2017-02-10 20:08    [W:0.043 / U:2.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site