[lkml]   [2017]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: polarity inversion on LS1021a

On 04/12/17 15:11, Rasmus Villemoes wrote:
> The LS1021A has a standard GIC-400, but allows inverting the polarity of
> six external interrupt lines via a certain register, effectively
> supporting IRQ_TYPE_LEVEL_LOW and IRQ_TYPE_EDGE_FALLING for those.
> I'm trying to figure out how one would add support for this. The patch
> below works but is obviously just meant to help show what I mean, so
> please don't comment on all the things that are wrong with it.
> It feels wrong to create a whole new irqchip driver copy-pasting the
> entire irg-gic.c, but I can't figure out how and where one could hook
> into the existing one. Any pointers on how to do this properly will be
> greatly appreciated.

You're missing the usual trick, which is to use a stacked irqchip for
these particular interrupts. See drivers/irqchip/irq-mtk-sysirq.c which
does exactly that. Bonus point if you make it a generic driver that can
be reused by other vendors.

Your patch has been erased in order to protect the innocents ;-).


Jazz is not dead. It just smells funny...

 \ /
  Last update: 2017-12-04 16:24    [W:0.265 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site