lkml.org 
[lkml]   [2017]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: hide unused allocate_percpu_fixmap_ptes

* Arnd Bergmann <arnd@arndb.de> wrote:

> The new function is not always used, causing a warning whenever
> CONFIG_CPU_SUP_INTEL is disabled:
>
> arch/x86/kernel/cpu/common.c:522:20: error: 'allocate_percpu_fixmap_ptes' defined but not used [-Werror=unused-function]
>
> Hide it in the same #ifdef.
>
> Fixes: 3015f86f838c ("x86/fixmap: Add debugstore entries to cpu_entry_area")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/x86/kernel/cpu/common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 6444f91e8d3c..6f354416a67f 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -519,11 +519,13 @@ static DEFINE_PER_CPU_PAGE_ALIGNED(struct entry_stack_page,
> * Force the population of PMDs for not yet allocated per cpu
> * memory like debug store buffers.
> */
> +#ifdef CONFIG_CPU_SUP_INTEL
> static void __init allocate_percpu_fixmap_ptes(int idx, int pages)
> {
> for (; pages; pages--, idx--)
> __set_fixmap(idx, 0, PAGE_NONE);
> }
> +#endif

Ok, this fix should be moot as the allocate_percpu_fixmap_ptes() is gone from the
latest versions of PTI.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-12-30 09:37    [W:0.023 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site