lkml.org 
[lkml]   [2017]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] USB: host: Use zeroing memory allocator rather than allocator/memset
On Sat, 30 Dec 2017, Himanshu Jha wrote:

> On Sat, Dec 30, 2017 at 11:41:19AM -0500, Alan Stern wrote:
> > On Sat, 30 Dec 2017, Himanshu Jha wrote:
> >
> > > Use dma_zalloc_coherent for allocating zeroed
> > > memory and remove unnecessary memset function.
> > >
> > > Done using Coccinelle.
> > > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
> > > 0-day tested with no failures.
> > >
> > > Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> > > ---
> > > drivers/usb/host/uhci-hcd.c | 7 +++----
> > > drivers/usb/host/xhci-mem.c | 7 ++-----
> > > 2 files changed, 5 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
> > > index f5c9021..ac53398 100644
> > > --- a/drivers/usb/host/uhci-hcd.c
> > > +++ b/drivers/usb/host/uhci-hcd.c
> > > @@ -600,15 +600,14 @@ static int uhci_start(struct usb_hcd *hcd)
> > > uhci->dentry = dentry;
> > > #endif
> > >
> > > - uhci->frame = dma_alloc_coherent(uhci_dev(uhci),
> > > - UHCI_NUMFRAMES * sizeof(*uhci->frame),
> > > - &uhci->frame_dma_handle, GFP_KERNEL);
> > > + uhci->frame = dma_zalloc_coherent(uhci_dev(uhci),
> > > + UHCI_NUMFRAMES * sizeof(*uhci->frame),
> > > + &uhci->frame_dma_handle, GFP_KERNEL);
> >
> > Please don't change the existing whitespace scheme when you make
> > changes like this one.
>
> Thanks for the feedback!
> Do I need to send v2 for this ?

Okay, yes, go ahead.

Alan Stern

\
 
 \ /
  Last update: 2017-12-30 20:27    [W:0.035 / U:14.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site