lkml.org 
[lkml]   [2017]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 01/11] block_dev: Support checking inode permissions in lookup_bdev()
Hi,

On Fri, Dec 22, 2017 at 7:59 PM, Coly Li <i@coly.li> wrote:
> On 22/12/2017 10:32 PM, Dongsu Park wrote:
> Hi Dongsu,
>
> Could you please use a macro like NO_PERMISSION_CHECK to replace hard
> coded 0 ? At least for me, I don't need to check what does 0 mean in the
> new lookup_bdev().

I see. I'll do that.

Thanks,
Dongsu

> Thanks.
>
> Coly Li
>
>> ---
>> drivers/md/bcache/super.c | 2 +-
>> drivers/md/dm-table.c | 2 +-
>> drivers/mtd/mtdsuper.c | 2 +-
>> fs/block_dev.c | 13 ++++++++++---
>> fs/quota/quota.c | 2 +-
>> include/linux/fs.h | 2 +-
>> 6 files changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>> index b4d28928..acc9d56c 100644
>> --- a/drivers/md/bcache/super.c
>> +++ b/drivers/md/bcache/super.c
>> @@ -1967,7 +1967,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
>> sb);
>> if (IS_ERR(bdev)) {
>> if (bdev == ERR_PTR(-EBUSY)) {
>> - bdev = lookup_bdev(strim(path));
>> + bdev = lookup_bdev(strim(path), 0);
>> mutex_lock(&bch_register_lock);
>> if (!IS_ERR(bdev) && bch_is_open(bdev))
>> err = "device already registered";
>> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
>> index 88130b5d..bca5eaf4 100644
> [snip]
>
>
> --
> Coly Li

\
 
 \ /
  Last update: 2017-12-23 13:02    [W:0.117 / U:27.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site