lkml.org 
[lkml]   [2017]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.4 75/78] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"
Hi,

On Fri, Dec 22, 2017 at 09:46:56AM +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This reverts commit ffc7565746bb2fc063fc0f484c55ef6d8951a6ee which is
> commit a0085f2510e8976614ad8f766b209448b385492f upstream.
>
> It causes problems with working systems, as noted by a number of the
> ChromeOS developers.
>
> Cc: Sukumar Ghorai <sukumar.ghorai@intel.com>
> Cc: Amit K Bag <amit.k.bag@intel.com>
> Cc: Oliver Neukum <oneukum@suse.com>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Reported-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

FWIW:
Acked-by: Brian Norris <briannorris@chromium.org>

Thanks for working past the confusion.

> ---
> drivers/bluetooth/btusb.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1050,10 +1050,6 @@ static int btusb_open(struct hci_dev *hd
> return err;
>
> data->intf->needs_remote_wakeup = 1;
> - /* device specific wakeup source enabled and required for USB
> - * remote wakeup while host is suspended
> - */
> - device_wakeup_enable(&data->udev->dev);
>
> if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags))
> goto done;
> @@ -1117,7 +1113,6 @@ static int btusb_close(struct hci_dev *h
> goto failed;
>
> data->intf->needs_remote_wakeup = 0;
> - device_wakeup_disable(&data->udev->dev);
> usb_autopm_put_interface(data->intf);
>
> failed:
>
>

\
 
 \ /
  Last update: 2017-12-22 18:33    [W:0.272 / U:4.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site