Messages in this thread |  | | Date | Wed, 20 Dec 2017 13:57:30 -0500 (EST) | Subject | Re: [PATCH v3,net-next 2/2] ip6_gre: fix potential memory leak in ip6erspan_rcv | From | David Miller <> |
| |
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com> Date: Wed, 20 Dec 2017 10:07:01 +0800
> If md is NULL, tun_dst must be freed, otherwise it will cause memory > leak. > > Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode") > Cc: William Tu <u9012063@gmail.com> > Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Applied.
> @@ -550,8 +550,10 @@ static int ip6erspan_rcv(struct sk_buff *skb, int gre_hdr_len, > > info = &tun_dst->u.tun_info; > md = ip_tunnel_info_opts(info); > - if (!md) > + if (!md) { > + dst_release((struct dst_entry *)tun_dst); > return PACKET_REJECT; > + } > > memcpy(md, pkt_md, sizeof(*md));
I agree with William that 'md' should never be NULL here, but that check existing before your changes so removing it is a separate patch altogether.
|  |