This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri Mar 31 02:28:59 2023 >From mailfetcher Wed Dec 20 10:10:52 2017 Envelope-to: lkml@grols.ch Delivery-date: Wed, 20 Dec 2017 10:10:51 +0100 Received: from srv.grols.ch [5.172.41.101] by 0359fc81c977 with IMAP (fetchmail-6.3.26) for (single-drop); Wed, 20 Dec 2017 10:10:52 +0100 (CET) Received: from vger.kernel.org ([209.132.180.67]) by home.grols.ch with esmtp (Exim 4.89) (envelope-from ) id 1eRaOp-0002Re-AD for lkml@grols.ch; Wed, 20 Dec 2017 10:10:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754261AbdLTJKW (ORCPT ); Wed, 20 Dec 2017 04:10:22 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:33240 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752886AbdLTJKS (ORCPT ); Wed, 20 Dec 2017 04 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1eRaOF-0006Qx-5V; Wed, 20 Dec 2017 09:10:15 Subject: Re: [PATCH] mei: fix incorrect logical operator in if statement To: "Winkler, Tomas" , Arnd Bergmann , Greg Kroah-Hartman Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20171219173530.15864-1-colin.king@canonical.com> <5B8DA87D05A7694D9FA63FD143655C1B74A82576@hasmsx108.ger.corp.intel.com> From: Colin Ian King Message-Id: Date: Wed, 20 Dec 2017 09:10:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 Mime-Version: 1.0 In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B74A82576@hasmsx108.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org Received-SPF: none client-ip=209.132.180.67; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org X-Spam-Score: 3.8 X-Spam-Score-Bar: +++ X-Spam-Action: no action X-Spam-Report: Action: no action Symbol: ARC_NA(0.00) Symbol: R_DKIM_NA(0.00) Symbol: ASN(0.00) Symbol: BAYES_SPAM(4.00) Symbol: FROM_NEQ_ENVFROM(0.00) Symbol: DMARC_POLICY_SOFTFAIL(0.10) Symbol: R_SPF_NA(0.00) Symbol: MIME_GOOD(-0.10) Symbol: RCPT_COUNT_FIVE(0.00) Sym On 20/12/17 08:58, Winkler, Tomas wrote: > >> From: Colin Ian King >> >> The current expression using the || operator is always true because >> dev->dev_state cannot be equal to two different values at the same time. >> Fix this by replacing the || with &&. >> >> Detected by CoverityScan, CID#1463042 ("Constant expression result") >> >> Fixes: 8d52af6795c0 ("mei: speed up the power down flow") >> Signed-off-by: Colin Ian King > Shame on me. No worries, that's why I run static analysis linux-next. > Ack. > Tomas > >> --- >> drivers/misc/mei/hw-me.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index >> 0b21f9ec00f5..334ab02e1de2 100644 >> --- a/drivers/misc/mei/hw-me.c >> +++ b/drivers/misc/mei/hw-me.c >> @@ -1261,7 +1261,7 @@ irqreturn_t mei_me_irq_thread_handler(int irq, >> void *dev_id) >> break; >> >> if (rets && >> - (dev->dev_state != MEI_DEV_RESETTING || >> + (dev->dev_state != MEI_DEV_RESETTING && >> dev->dev_state != MEI_DEV_POWER_DOWN)) { >> dev_err(dev->dev, "mei_irq_read_handler ret = >> %d.\n", >> rets); >> -- >> 2.14.1 > > N�����r��y���b�X��ǧv�^�)޺{.n�+���z�ޖ6���+�)���w*jg��������ݢj/���z�ޖ��2�ޙ���&�)ߡ�a�����G���h��j:+v���w�٥ >