lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH for-4.15] wireless: create, don't append, to shipped-certs.c
From
Date
On Tue, 2017-12-19 at 11:23 -0800, Brian Norris wrote:
>
> In practice, this is seen often by having a separate source and build
> directory, where the build artifacts remain but the source tree changes
> (even if Seth's cert doesn't change, it might get created/removed when
> checking out different source revisions).
>
> I don't see why this rule should be an append; we're writing the file
> all in one go.

Yeah, that was an oversight from the code prior to my changes to make
it write it only once.

> Fixes: 90a53e4432b1 ("cfg80211: implement regdb signature checking")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> This is an error introduced in 4.15-rc1.
>
> I've seen other errors reported by Paul and Damian (CC'd); I think Paul's
> failure was fixed already, but Damian might have still been having problems
> with not having a "clean" environment. Perhaps he was hitting this bug?

I'm not really sure what that problem was - I think a combination of
missing clean-files and this perhaps? Anyway, I applied another fix for
this today, and it's on the way to Linus's tree, along with the missing
clean-files and a conversion to non-binary files so that patches work
better.

johannes

\
 
 \ /
  Last update: 2017-12-19 21:12    [W:0.031 / U:1.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site