lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] sched/fair: Correct obsolete comment about cpufreq_update_util
On Fri, Dec 15, 2017 at 07:39:43AM -0800, Joel Fernandes wrote:
> Since the remote cpufreq callback work, the cpufreq_update_util call can happen
> from remote CPUs. The comment about local CPUs is thus obsolete. Update it
> accordingly.
>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Joel Fernandes <joelaf@google.com>

Sure, ACK

> ---
> kernel/sched/fair.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 2fe3aa853e4d..1b10821d8380 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3020,9 +3020,7 @@ static inline void cfs_rq_util_change(struct cfs_rq *cfs_rq)
> /*
> * There are a few boundary cases this might miss but it should
> * get called often enough that that should (hopefully) not be
> - * a real problem -- added to that it only calls on the local
> - * CPU, so if we enqueue remotely we'll miss an update, but
> - * the next tick/schedule should update.
> + * a real problem.
> *
> * It will not get called when we go idle, because the idle
> * thread is a different class (!fair), nor will the utilization
> --
> 2.15.1.504.g5279b80103-goog
>

\
 
 \ /
  Last update: 2017-12-19 19:03    [W:0.143 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site