lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mm: Make follow_pte_pmd an inline
On Tue, Dec 19, 2017 at 09:05:42AM -0800, Joe Perches wrote:
> On Tue, 2017-12-19 at 08:58 -0800, Matthew Wilcox wrote:
> > + /* (void) is needed to make gcc happy */
> > + (void) __cond_lock(*ptlp,
> > + !(res = __follow_pte_pmd(mm, address, start, end,
> > + ptepp, pmdpp, ptlp)));
>
> This seems obscure and difficult to read. Perhaps:
>
> res = __follow_pte_pmd(mm, address, start, end, ptepp, pmdpp, ptlp);
> (void)__cond_lock(*ptlp, !res);

Patch 1 moves the code. Patch 2 cleans it up ;-)

\
 
 \ /
  Last update: 2017-12-19 18:13    [W:0.278 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site