lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] net: arc_emac: fix arc_emac_rx() error paths
    From
    From: Alexander Kochetkov <al.kochet@gmail.com>
    Date: Tue, 19 Dec 2017 18:49:48 +0300

    >> And then you unmap it. "addr" is the new DMA mapping, not the old one.
    >
    > The old mapping should be unmapped here. It refer to old skb what contains already
    > received packet. Because buffer doesn’t belong to EMAC anymore.
    > That old mapping point to old skb buffer. And netif_receive_skb() will be
    > called for old skb after that.

    I misread the code, sorry. I saw the dma_unmap_addr(xxx, addr) and just
    considered 'addr' as the local variable. It's not, it's in fact the
    TX struct member.

    Let me look at this some more. ;-)
    \
     
     \ /
      Last update: 2017-12-19 17:42    [W:4.416 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site