[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] devres: use MACRO instead of function for devm_ioremap
Hi Greg,

On 2017/12/19 16:46, Greg KH wrote:
> On Sat, Nov 25, 2017 at 05:23:33PM +0800, Yisheng Xie wrote:
>> Default ioremap is ioremap_nocache, so devm_ioremap has the same function
>> with devm_ioremap_nocache, which may just be killed. However, there are
>> many places which use devm_ioremap_nocache, while many use devm_ioremap.
>> This patch is to use MACRO for devm_ioremap, which will reduce the size of
>> devres.o from 206824 Bytes to 203768 Bytes.
> Ok, the idea is good, but why not just get rid of the callers of
> devm_ioremap_nocache() instead and have them call devm_ioremap() if they
> really are the same thing? No need to keep a macro around for the
> duplicate thing, just delete the one and things are much better.

Yeah, I thought someone may still want to use devm_ioremap_nocache().

I will take your suggestion in next version and kill devm_ioremap_nocache().

Yisheng Xie
> thanks,
> greg k-h
> .

 \ /
  Last update: 2017-12-19 11:53    [W:0.254 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site