lkml.org 
[lkml]   [2017]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH v2] xen/balloon: Mark unallocated host memory as UNUSABLE
>>> On 19.12.17 at 10:21, <jgross@suse.com> wrote:
> On 19/12/17 09:23, Jan Beulich wrote:
>>>>> On 18.12.17 at 23:22, <boris.ostrovsky@oracle.com> wrote:
>>> +void __init arch_xen_balloon_init(struct resource *hostmem_resource)
>>> +{
>>> + struct xen_memory_map memmap;
>>> + int rc;
>>> + unsigned int i, last_guest_ram;
>>> + phys_addr_t max_addr = max_pfn << PAGE_SHIFT;
>>
>> PFN_PHYS() as right now you still have an issue on 32-bit.
>
> Why? PFN_PHYS is defined as:
>
> #define PFN_PHYS(x) ((phys_addr_t)(x) << PAGE_SHIFT)

Well, that's why I suggested its use (just like you did in your
own review). IOW - now I'm confused.

Jan

\
 
 \ /
  Last update: 2017-12-19 10:28    [W:0.097 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site