lkml.org 
[lkml]   [2017]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/6] dt: bindings: lp8860: Update DT label binding
From
Date
Rob

On 12/15/2017 04:59 PM, Rob Herring wrote:
> On Tue, Dec 12, 2017 at 04:01:39PM -0600, Dan Murphy wrote:
>> Update the lp8860 label binding to the LED
>> standard as documented in
>>
>> Documentation/devicetree/bindings/leds/common.txt
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v4 - No changes
>>
>> v3 - Added address and size cells, updated label with color and inserted spaces
>> around the reg node - https://patchwork.kernel.org/patch/10093749/
>> v2 - Added reg to child node and made it required
>>
>> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 17 +++++++++++++++--
>> 1 file changed, 15 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index b9d09acbaa73..c3d64ade1e26 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -9,20 +9,33 @@ Required properties:
>> - compatible :
>> "ti,lp8860"
>> - reg : I2C slave address
>> - - label : Used for naming LEDs
>> + - #address-cells : 1
>> + - #size-cells : 0
>>
>> Optional properties:
>> - enable-gpios : gpio pin to enable (active high)/disable the device.
>> - vled-supply : LED supply
>>
>> +Required child properties:
>> + - reg : 0
>> +
>
> This should be in previous patch?


No this is the reg node for the child property. The child property is
introduced in this patch. So this should be correct

Dan

>
>> +Optional child properties:
>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> Example:
>>
>> led-controller@2d {
>> compatible = "ti,lp8860";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> reg = <0x2d>;
>> - label = "display_cluster";
>> enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> vled-supply = <&vbatt>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + label = "white:display_cluster";
>> + };
>> }
>>
>> For more product information please see the link below:
>> --
>> 2.15.0.124.g7668cbc60
>>


--
------------------
Dan Murphy

\
 
 \ /
  Last update: 2017-12-18 14:09    [W:0.070 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site