lkml.org 
[lkml]   [2017]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] Staging: rtl8723bs: Replace true with x and false with !x
From
Date
On Sun, 2017-12-17 at 01:45 -0800, Joe Perches wrote:
> On Sun, 2017-12-17 at 15:07 +0530, Shreeya Patel wrote:
> >
> > Replace true and false keywords with "x" and "!x"
> > respectively to follow the kernel coding style.
> []
> >
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> > b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> []
> >
> > @@ -191,8 +191,8 @@ static u32 sdio_read32(struct intf_hdl
> > *pintfhdl, u32 addr)
> >   rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC,
> > &bMacPwrCtrlOn);
> >   if (
> >   ((deviceId == WLAN_IOREG_DEVICE_ID) && (offset <
> > 0x100)) ||
> > - (false == bMacPwrCtrlOn) ||
> > - (true == adapter_to_pwrctl(padapter)-
> > >bFwCurrentInPSMode)
> > + (!bMacPwrCtrlOn) ||
> When you do these sorts of conversions can you
> please remove the unnecessary parentheses too?
>
Yes, surely I'll keep this in mind.

Thank you

\
 
 \ /
  Last update: 2017-12-17 10:52    [W:0.036 / U:3.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site