lkml.org 
[lkml]   [2017]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
Subject[PATCH SERIES 1: 00/15] staging:lustre: convert most LIBCFS*ALLOC to k*malloc
Lustre has some "convenience" macros for allocating and freeing
memory.
They:
- warn if called from interrupt context
- use kvmalloc
- assume GFP_NOFS (which kvmalloc doesn't support)
- print an error if the allocation fails
- initialize the memory to zeroes.

though the _ATOMIC version skips the first three.

- kmalloc family functions already produce the warning.
- kvmalloc is best kept for allocations which might be large, and
where GFP_KERNEL is permitted
- Assuming GFP_NOFS does hurt much for small allocation - though it
increases the chance of failure a little - but is unnecessary
in many cases and shouldn't be assumed.
- Giving an error on failure can be achieved with CONFIG_SLAB_DEBUG.
- Initializing to zeroes, where needed, can be done with __GFP_ZERO
or kzalloc()

So having these "convenience" functions tends to obscure the intention
of the code by reducing the variety of calls (homogenising the code).

This series converts many of the calls to kmalloc or kvmalloc or
similar, and converts the corresponding LIBCFS_FREE() calls to kfree()
or kvfree().

The LIBCFS_CPT_ALLOC() calls have not been changed as they are a
little less straight forward, and deserve closer analysis before a
clean conversion is possible.

This series does not remove the zeroing in all cases where is isn't
needed, but does remove it in some.
Similarly GFP_NOFS is left is some cases where it might not be
necessary. These omissions can be rectified later following proper
analysis.

I plan to send out several sets of lustre patches today (Christmas
holiday reading :-) so I've labeled this "PATCH SERIES 1" to it is
easier to apply them in the right order, if there are acceptable.

Thanks,
NeilBrown


---

NeilBrown (15):
staging: lustre: lnet-lib: opencode some alloc/free functions.
staging: lustre: lnet: discard CFS_ALLOC_PTR
staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.
staging: lustre: lnet: switch to cpumask_var_t
staging: lustre: lnet: selftest: don't allocate small strings.
staging: lustre: lnet: use kmalloc/kvmalloc in router_proc
staging: lustre: change some LIBCFS_ALLOC calls to k?alloc(GFP_KERNEL)
staging: lustre: Convert more LIBCFS_ALLOC allocation to direct GFP_KERNEL
staging: lustre: more LIBCFS_ALLOC conversions to GFP_KERNEL allocations.
staging: lustre: more conversions to GFP_KERNEL allocations.
staging: lustre: lnet-route: use kmalloc for small allocation
staging: lustre: use kmalloc for allocating ksock_tx
staging: lustre: cfs_percpt_alloc: use kvmalloc(GFP_KERNEL)
staging: lustre: opencode LIBCFS_ALLOC_ATOMIC calls.
staging: lustre: remove LIBCFS_ALLOC and LIBCFS_ALLOC_ATOMIC


.../lustre/include/linux/libcfs/libcfs_cpu.h | 4
.../lustre/include/linux/libcfs/libcfs_private.h | 22 --
.../lustre/include/linux/libcfs/libcfs_string.h | 4
.../lustre/include/linux/libcfs/linux/linux-cpu.h | 4
.../staging/lustre/include/linux/lnet/lib-lnet.h | 63 -------
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 55 +++---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 4
.../lustre/lnet/klnds/o2iblnd/o2iblnd_modparams.c | 4
.../staging/lustre/lnet/klnds/socklnd/socklnd.c | 46 ++---
.../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 6 -
.../lustre/lnet/klnds/socklnd/socklnd_proto.c | 8 -
drivers/staging/lustre/lnet/libcfs/hash.c | 18 +-
drivers/staging/lustre/lnet/libcfs/libcfs_cpu.c | 6 -
drivers/staging/lustre/lnet/libcfs/libcfs_lock.c | 6 -
drivers/staging/lustre/lnet/libcfs/libcfs_mem.c | 15 +-
drivers/staging/lustre/lnet/libcfs/libcfs_string.c | 12 +
.../staging/lustre/lnet/libcfs/linux/linux-cpu.c | 126 ++++++-------
.../lustre/lnet/libcfs/linux/linux-module.c | 4
drivers/staging/lustre/lnet/libcfs/module.c | 9 -
drivers/staging/lustre/lnet/libcfs/workitem.c | 8 -
drivers/staging/lustre/lnet/lnet/api-ni.c | 25 +--
drivers/staging/lustre/lnet/lnet/config.c | 42 ++--
drivers/staging/lustre/lnet/lnet/lib-eq.c | 15 +-
drivers/staging/lustre/lnet/lnet/lib-md.c | 8 -
drivers/staging/lustre/lnet/lnet/lib-me.c | 10 +
drivers/staging/lustre/lnet/lnet/lib-move.c | 24 +--
drivers/staging/lustre/lnet/lnet/lib-msg.c | 6 -
drivers/staging/lustre/lnet/lnet/lib-ptl.c | 2
drivers/staging/lustre/lnet/lnet/lib-socket.c | 14 +
drivers/staging/lustre/lnet/lnet/net_fault.c | 10 +
drivers/staging/lustre/lnet/lnet/nidstrings.c | 8 -
drivers/staging/lustre/lnet/lnet/peer.c | 2
drivers/staging/lustre/lnet/lnet/router.c | 31 +--
drivers/staging/lustre/lnet/lnet/router_proc.c | 40 ++--
drivers/staging/lustre/lnet/selftest/conctl.c | 191 ++++----------------
drivers/staging/lustre/lnet/selftest/conrpc.c | 10 +
drivers/staging/lustre/lnet/selftest/console.c | 83 ++++-----
drivers/staging/lustre/lnet/selftest/framework.c | 26 +--
drivers/staging/lustre/lnet/selftest/module.c | 7 -
drivers/staging/lustre/lnet/selftest/rpc.c | 16 +-
drivers/staging/lustre/lnet/selftest/selftest.h | 2
.../lustre/lustre/obdclass/lprocfs_status.c | 21 +-
42 files changed, 381 insertions(+), 636 deletions(-)

--
Signature

\
 
 \ /
  Last update: 2017-12-18 01:56    [W:0.074 / U:1.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site