[lkml]   [2017]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] lib/usercopy: fix sparse errors
> The change is good.
> The commit message would better simply describe the problem instead
> of describing the symptom. For example, something like:
> The function _copy_to_user() is used to copy to address space.
> As such, the destination pointer should be annotated with
> '__user'.
> However, the function has the annotation wrongly, on the
> source instead of the destination (copy & paste error?).
> Fix this by moving the __user annotation to the correct
> argument.

FWIW, I've committed it with

Fix misannotated out-of-line _copy_to_user()

Destination is a kernel pointer and source - a userland one
is _copy_from_user(); _copy_to_user() is the other way round.

 \ /
  Last update: 2017-12-17 18:32    [W:0.037 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site