lkml.org 
[lkml]   [2017]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/6] dt: bindings: lp8860: Update bindings for lp8860
On Tue, Dec 12, 2017 at 04:01:38PM -0600, Dan Murphy wrote:
> Update the lp8860 bindings to fix various issues
> found. Add address-cells and size-cells, rename

You are doing this in the next patch...

> enable-gpio to enable-gpios, update the node name
> to the device name and indent the node example.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v4 - No changes
>
> v3 - Indicatd enable-gpios is active high, moved address and size cells to child
> node patch and updated parent DT node name - https://patchwork.kernel.org/patch/10093745/
> v2 - New patch
>
> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> index aad38dd94d4b..b9d09acbaa73 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
> @@ -6,22 +6,22 @@ current sinks that can be controlled by a PWM input
> signal, a SPI/I2C master, or both.
>
> Required properties:
> - - compatible:
> + - compatible :
> "ti,lp8860"
> - - reg - I2C slave address
> - - label - Used for naming LEDs
> + - reg : I2C slave address
> + - label : Used for naming LEDs
>
> Optional properties:
> - - enable-gpio - gpio pin to enable/disable the device.
> - - supply - "vled" - LED supply
> + - enable-gpios : gpio pin to enable (active high)/disable the device.
> + - vled-supply : LED supply
>
> Example:
>
> -leds: leds@6 {
> +led-controller@2d {
> compatible = "ti,lp8860";
> reg = <0x2d>;
> label = "display_cluster";
> - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> vled-supply = <&vbatt>;
> }
>
> --
> 2.15.0.124.g7668cbc60
>

\
 
 \ /
  Last update: 2017-12-15 23:58    [W:0.147 / U:3.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site