Messages in this thread |  | | Subject | Re: [PATCH v2 6/7] i3c: master: Add driver for Cadence IP | From | Randy Dunlap <> | Date | Thu, 14 Dec 2017 12:25:14 -0800 |
| |
On 12/14/2017 12:17 PM, Boris Brezillon wrote: >>> + events.events = I3C_CCC_EVENT_HJ | I3C_CCC_EVENT_MR; >>> + ret = i3c_master_enec_locked(m, I3C_BROADCAST_ADDR, &events); >>> + if (ret) >>> + pr_info("Failed to re-enable H-J"); >> Not very good info... > What do you mean? Is it the H-J that bothers you (I can replace it by > 'Hot-Join'), or is it something else?
Who is the message for? If it's for developers, you could use pr_debug(). If it's for users, it needs more clarity.
Does it print the source of the message? (module name e.g.) and yes, Hot-Join would be better IMO.
-- ~Randy
|  |