lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] rtc: Add tracepoints for RTC system
On 13 December 2017 at 20:23, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 13/12/2017 at 12:16:03 +0000, Mark Brown wrote:
>> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
>>
>> > Also, I think we could try having only the time64_t in the ring buffer.
>> > Maybe I'm wrong but I think tools reading that buffer can do the
>> > conversion themselves. Maybe I don't understand correctly how
>> > tracepoints work and this doesn't make sense, tell me.
>>
>> Tools reading the buffer can do the conversion themselves but it's also
>> useful for users to just view the log directly via tracing/trace
>> sometimes. OTOH the whole point is to be low overhead so...
>
> Yes, that is why I suggest keeping both representation in the printk
> but only time64_t in the buffer. And this would be more convenient if we
> add a way to pretty print a time64_t in vsprintf.

OK. I will only keep time64_t in the buffer. Thanks for all your comments.

--
Baolin.wang
Best Regards

\
 
 \ /
  Last update: 2017-12-14 04:08    [W:0.065 / U:4.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site