lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/x86: dell-smo8800: Possible unnecessary 'out of memory' message
On Wednesday 13 December 2017 13:53:54 Dhaval Shah wrote:
> Removed Possible unnecessary 'out of memory' message checkpatch warnings.
> Issue found by checkpatch.
>
> Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
> ---
> drivers/platform/x86/dell-smo8800.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c
> index 1d87237bc731..9590d5e7c5ca 100644
> --- a/drivers/platform/x86/dell-smo8800.c
> +++ b/drivers/platform/x86/dell-smo8800.c
> @@ -150,10 +150,8 @@ static int smo8800_add(struct acpi_device *device)
> struct smo8800_device *smo8800;
>
> smo8800 = devm_kzalloc(&device->dev, sizeof(*smo8800), GFP_KERNEL);
> - if (!smo8800) {
> - dev_err(&device->dev, "failed to allocate device data\n");

Hi! Any particular reason for removing error message?

> + if (!smo8800)
> return -ENOMEM;
> - }
>
> smo8800->dev = &device->dev;
> smo8800->miscdev.minor = MISC_DYNAMIC_MINOR;

--
Pali Rohár
pali.rohar@gmail.com

\
 
 \ /
  Last update: 2017-12-13 09:31    [W:0.043 / U:22.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site