lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments
On Wed, Dec 13, 2017 at 11:28:51PM +0100, Maciej S. Szmigiero wrote:

> > - /*
> > - * If we're in synchronous mode, and the SSI is already enabled,
> > - * then STCCR is already set properly.
> > - */
> > + /* To support simultaneous TX and RX, bypass it if SSI is enabled */
> > if (enabled && ssi->cpu_dai_drv.symmetric_rates)
> > return 0;
> >
>
> I would say that the old comment described better what is happening -
> since in synchronous (& non-AC'97) mode STCCR controls both TX and RX
> the first direction that is started (either playback or capture) is the
> only direction that needs to configure SSI in hw_params().

There is also an SCR register configuration in this hw_params(),
so the old comment has to be updated. But I would take it into
consideration and revise a bit.

Thanks.

\
 
 \ /
  Last update: 2017-12-13 23:36    [W:0.071 / U:1.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site