lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] leds: as3645a: Fix checkpatch warnings
From
Date
Hi Dan,

checkpatch.pl doesn't want to be mentioned in the patch subject :-)

"WARNING: A patch subject line should describe the change not the tool
that found it"

Preferably I'd see two separate patches.

Also, line length limit for the commit description is 75 characters.
Please use whole available space.

--
Best regards,
Jacek Anaszewski

On 12/12/2017 10:50 PM, Dan Murphy wrote:
> Fix two checkpatch warnings for 80 char
> length and for a quoted string across multiple
> line warnings.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/leds/leds-as3645a.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..f883616d9e60 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,
> {
> struct as3645a *flash = fled_to_as3645a(fled);
>
> - flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
> + flash->flash_current = as3645a_current_to_reg(flash, true,
> + brightness_ua);
>
> return as3645a_set_current(flash);
> }
> @@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)
>
> /* Verify the chip model and version. */
> if (model != 0x01 || rfu != 0x00) {
> - dev_err(dev, "AS3645A not detected "
> - "(model %d rfu %d)\n", model, rfu);
> + dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> + model, rfu);
> return -ENODEV;
> }
>
>

\
 
 \ /
  Last update: 2017-12-13 21:30    [W:0.066 / U:4.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site