lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled
2017-12-13 16:39 GMT+01:00 Mark Brown <broonie@kernel.org>:
> On Wed, Dec 13, 2017 at 10:28:11AM +0100, Bartosz Golaszewski wrote:
>> User space can initiate concurrent access to regmap over debugfs and,
>> if the locking is disabled, we can't protect it. Don't create the
>> debugfs entries at all in this case.
>
> I (probably unsurprisingly) prefer my version that I posted yesterday as
> it gives us the trivial memory saving of not having the flag if debugfs
> is disabled but more importantly from my point of view keeps the
> interface to debugfs as function calls in the core.

It went into spam in my mailbox for some reason, that's why I didn't see it.

Yes, it looks better. I'll drop it from the series.

Thanks,
Bartosz

\
 
 \ /
  Last update: 2017-12-13 16:47    [W:2.059 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site