lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 2/4] KVM: X86: Add Paravirt TLB Shootdown
From
Date
On 13/12/2017 02:33, Wanpeng Li wrote:
> @@ -53,6 +54,7 @@ struct kvm_steal_time {
>
> #define KVM_VCPU_NOT_PREEMPTED (0 << 0)
> #define KVM_VCPU_PREEMPTED (1 << 0)
> +#define KVM_VCPU_SHOULD_FLUSH (1 << 1)
>
> #define KVM_CLOCK_PAIRING_WALLCLOCK 0

Two issues with the name:

1) it doesn't say *what* is flushed

2) in the usual meaning of "should", it would be just a recommendation
i.e. it's fine not to flush the TLB. This is not true in this case, so
KVM_VCPU_FLUSH_TLB is better.

Paolo

\
 
 \ /
  Last update: 2017-12-13 13:33    [W:0.272 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site