lkml.org 
[lkml]   [2017]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines
Date
HI

Thanks a lot for the review.
________________________________________
> From: Philippe Ombredanne <pombredanne@nexb.com>
> Sent: Wednesday, December 13, 2017 2:54 PM
> To: Dhaval Shah
> Cc: pali.rohar@gmail.com; Darren Hart; Andy Shevchenko; platform-driver-x86@vger.kernel.org; LKML
> Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines
>
> Dhaval,
>
> On Wed, Dec 13, 2017 at 9:23 AM, Dhaval Shah
> <dhaval.shah@softnautics.com> wrote:
> > Resolved Block comments use * on subsequent lines checkpatch warnings.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
> > ---
> > drivers/platform/x86/dell-rbtn.c | 26 +++++++++++++-------------
> > drivers/platform/x86/dell-rbtn.h | 26 +++++++++++++-------------
> > 2 files changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c
> > index f3afe778001e..cab93c6dcd34 100644
> > --- a/drivers/platform/x86/dell-rbtn.c
> > +++ b/drivers/platform/x86/dell-rbtn.c
> > @@ -1,17 +1,17 @@
> > /*
> > - Dell Airplane Mode Switch driver
> > - Copyright (C) 2014-2015 Pali Rohár <pali.rohar@gmail.com>
> > -
> > - This program is free software; you can redistribute it and/or modify
> > - it under the terms of the GNU General Public License as published by
> > - the Free Software Foundation; either version 2 of the License, or
> > - (at your option) any later version.
> > -
> > - This program is distributed in the hope that it will be useful,
> > - but WITHOUT ANY WARRANTY; without even the implied warranty of
> > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > - GNU General Public License for more details.
> > -*/
> > + * Dell Airplane Mode Switch driver
> > + * Copyright (C) 2014-2015 Pali Rohár <pali.rohar@gmail.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
> > + */
>
> Do you mind using the new SPDX ids instead of this long legalese?
> You can check the doc patches from Thomas for details [1]
>
>
> [1] https://lkml.org/lkml/2017/12/4/934
This is different issue. If we need to fix the issue of this if we update SPDX licensing as well.
I am agree with you on the use of the new SPDX IDs instead of the long legalese.
For this, we have to add the text "// SPDX-License-Identifier: GPL-2.0" at the top of the file and remove the
whole license part and keep on copyright and Author name related info. After change, it looks like
// SPDX-License-Identifier: GPL-2.0
/*
* Dell Airplane Mode Switch driver
* Copyright (C) 2014-2015 Pali Rohár <pali.rohar@gmail.com>
*/

> --
> Cordially
> Philippe Ombredanne

\
 
 \ /
  Last update: 2017-12-13 10:53    [W:0.098 / U:7.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site