lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/urgent] x86/mm/kmmio: Fix mmiotrace for page unaligned addresses
On Tue, Dec 12, 2017 at 09:47:05AM -0500, Ilia Mirkin wrote:
> > So this 'thing' has huge gaping SMP holes in.
>
> Sure does! Probably why the following happens when mmiotrace is enabled:
>
> void enable_mmiotrace(void)
> {
> mutex_lock(&mmiotrace_mutex);
> if (is_enabled())
> goto out;
>
> if (nommiotrace)
> pr_info("MMIO tracing disabled.\n");
> kmmio_init();
> enter_uniprocessor();

^^^^^

Ah! I completely missed that. OK, that makes it much less broken :-)

If I don't forget, I'll add some comments to this file to clarify that.

Thanks!

> spin_lock_irq(&trace_lock);
> atomic_inc(&mmiotrace_enabled);
> spin_unlock_irq(&trace_lock);
> pr_info("enabled.\n");
> out:
> mutex_unlock(&mmiotrace_mutex);
> }

\
 
 \ /
  Last update: 2017-12-12 15:52    [W:0.111 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site