lkml.org 
[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 018/164] can: usb_8dev: cancel urb on -EPIPE and -EPROTO
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Martin Kelly <mkelly@xevo.com>

    commit 12147edc434c9e4c7c2f5fee2e5519b2e5ac34ce upstream.

    In mcba_usb, we have observed that when you unplug the device, the driver will
    endlessly resubmit failing URBs, which can cause CPU stalls. This issue
    is fixed in mcba_usb by catching the codes seen on device disconnect
    (-EPIPE and -EPROTO).

    This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it
    in the same way.

    Signed-off-by: Martin Kelly <mkelly@xevo.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/can/usb/usb_8dev.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/can/usb/usb_8dev.c
    +++ b/drivers/net/can/usb/usb_8dev.c
    @@ -524,6 +524,8 @@ static void usb_8dev_read_bulk_callback(
    break;

    case -ENOENT:
    + case -EPIPE:
    + case -EPROTO:
    case -ESHUTDOWN:
    return;


    \
     
     \ /
      Last update: 2017-12-12 15:10    [W:4.032 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site