[lkml]   [2017]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.14 005/164] serdev: ttyport: fix tty locking in close
4.14-stable review patch.  If anyone has any objections, please let me know.


From: Johan Hovold <>

commit 90dbad8cd6efccbdce109d5ef0724f8434a6cdde upstream.

Make sure to hold the tty lock as required when calling tty-driver
close() (e.g. to avoid racing with hangup()).

Note that the serport active flag is currently set under the lock at
controller open, but really isn't protected by it.

Fixes: cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
Signed-off-by: Johan Hovold <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/tty/serdev/serdev-ttyport.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -149,8 +149,10 @@ static void ttyport_close(struct serdev_

clear_bit(SERPORT_ACTIVE, &serport->flags);

+ tty_lock(tty);
if (tty->ops->close)
tty->ops->close(tty, NULL);
+ tty_unlock(tty);

tty_release_struct(tty, serport->tty_idx);

 \ /
  Last update: 2017-12-12 13:48    [W:0.484 / U:3.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site