lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] infiniband: cxgb4: use ktime_get for timestamps
Date
> Subject: Re: [PATCH] infiniband: cxgb4: use ktime_get for timestamps
>
> On Mon, Nov 27, 2017 at 12:44:53PM +0100, Arnd Bergmann wrote:
> > The debugfs file prints the difference between host timestamps as a
> > seconds/nanoseconds tuple, along with a 64-bit nanoseconds hardware
> > timestamp. The host time is read using getnstimeofday() which is
> > deprecated because of the y2038 overflow, and it suffers from time jumps
> > during settimeofday() and leap seconds.
> >
> > Converting to ktime_get_ts64() would solve those two, but I'm going
> > a little further here by changing to ktime_get() and printing 64-bit
> > nanoseconds on both host and hw timestamps. This simplifies the code
> > further and makes the output easier to understand.
> >
> > The format of the debugfs file obviously changes here, but this should
> > only be read by humans and not scripts, so I assume it's fine.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > drivers/infiniband/hw/cxgb4/device.c | 34
+++++++++++++++-------------------
> > drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 4 ++--
> > drivers/infiniband/hw/cxgb4/qp.c | 6 +++---
> > drivers/infiniband/hw/cxgb4/t4.h | 4 ++--
> > 4 files changed, 22 insertions(+), 26 deletions(-)
>
> Steve? This changes the format of the debugfs files, so please ack it
> if it is Ok..
>

I apologize for missing this patch initially. I think this is fine.

Acked-by: Steve Wise <swise@opengridcomputing.com>



---
This email has been checked for viruses by AVG.
http://www.avg.com

\
 
 \ /
  Last update: 2017-12-12 00:03    [W:0.076 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site