lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 04/15] soundwire: Add MIPI DisCo property helpers
On Mon, 11 Dec 2017 18:00:22 +0100,
Vinod Koul wrote:
>
> On Mon, Dec 11, 2017 at 05:10:17PM +0100, Takashi Iwai wrote:
> > On Wed, 06 Dec 2017 16:47:00 +0100,
> > Vinod Koul wrote:
> > >
> > > + /* TODO: Read audio mode */
> > > +
> > > + i++;
> > > + }
> >
> > Don't we use count argument for a sanity check?
>
> Not really as that iterator runs on each bit:
>
> for_each_set_bit(bit, &addr, 32) {
>
> so it will not go on endlessly and can max out when all the bits being set
> and stop.

Yes, that shouldn't happen. OTOH, only looking at the callee side,
one may wonder that the possible error would be dpn[] overflows the
given array size (=count). Though, looking at both caller and callee,
one realizes that it shouldn't happen, too.
(But then again wonders why passing count argument at all :)


Takashi

\
 
 \ /
  Last update: 2017-12-11 18:07    [W:0.077 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site