lkml.org 
[lkml]   [2017]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix resume on x86-32 machines

* Andy Lutomirski <luto@amacapital.net> wrote:

>
>
> > On Dec 10, 2017, at 1:38 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >
> >
> > After 4.15-rc2, suspend stopped working on Thinkpad X60. 5b06bbc
> > (unintentionally?) reordered stuff with respect to
> > fix_processor_context() on 32-bit and 64-bit. We undo that change on
> > 32-bit.
> >
>
> Can you explain what was wrong with the reordering? Your patch certainly *looks* incorrect.
>
> I'm guessing that the real issue is that 32-bit needs %fs restored early for TLS.

Does some early percpu primitive need GS as well perhaps?

Might be safest to restore both FS and GS early.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-12-11 16:14    [W:0.103 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site