lkml.org 
[lkml]   [2017]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver
Date
> -----Original Message-----
> From: Kun Yi [mailto:kunyi@google.com]
> Sent: Thursday, November 30, 2017 12:51 AM
> To: Oleksandr Shamray <oleksandrs@mellanox.com>
> Cc: gregkh@linuxfoundation.org; arnd@arndb.de; system-sw-low-level
> <system-sw-low-level@mellanox.com>; devicetree@vger.kernel.org;
> jiri@resnulli.us; Vadim Pasternak <vadimp@mellanox.com>; linux-
> api@vger.kernel.org; OpenBMC Maillist <openbmc@lists.ozlabs.org>; linux-
> kernel@vger.kernel.org; openocd-devel-owner@lists.sourceforge.net;
> mec@shout.net; Jiri Pirko <jiri@mellanox.com>; robh+dt@kernel.org; linux-
> serial@vger.kernel.org; tklauser@distanz.ch; mchehab@kernel.org;
> davem@davemloft.net; linux-arm-kernel@lists.infradead.org
> Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx
> families JTAG master driver
>
> Thanks for working on the driver, Oleksandr. I gave this a try on a board with
> Aspeed 2520. One question below:
>
> On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray
> <oleksandrs@mellanox.com> wrote:
> > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller.
> >
> > Driver implements the following jtag ops:
> > - freq_get;
> > - freq_set;
> > - status_get;
> > - idle;
> > - xfer;
> >

[..]

> > +
> > +static const struct jtag_ops aspeed_jtag_ops = {
> > + .freq_get = aspeed_jtag_freq_get,
> > + .freq_set = aspeed_jtag_freq_set,
> > + .status_get = aspeed_jtag_status_get,
> > + .idle = aspeed_jtag_idle,
> > + .xfer = aspeed_jtag_xfer,
> > + .mode_set = aspeed_jtag_mode_set };
> > +
> > +static int aspeed_jtag_probe(struct platform_device *pdev) {
> > + struct aspeed_jtag *aspeed_jtag;
> > + struct jtag *jtag;
> > + int err;
> > +
> > + if (!of_device_is_compatible(pdev->dev.of_node,
> > + "aspeed,aspeed-jtag"))
>
> Should this be "aspeed,ast2400-jtag"/"aspeed,ast2500-jtag" as specified in the
> compatible string below?
>

Yes


> > + return -ENOMEM;
> > +
> > + jtag = jtag_alloc(sizeof(*aspeed_jtag), &aspeed_jtag_ops);
> > + if (!jtag)
> > + return -ENODEV;
> > +
> > + platform_set_drvdata(pdev, jtag);
> > + aspeed_jtag = jtag_priv(jtag);
> > + aspeed_jtag->dev = &pdev->dev;
> > +

[..]

> > +
> > +MODULE_AUTHOR("Oleksandr Shamray <oleksandrs@mellanox.com>");
> > +MODULE_DESCRIPTION("ASPEED JTAG driver"); MODULE_LICENSE("GPL
> v2");
> > --
> > 1.7.1
> >
> --
> Regards,
> Kun

Thanks.

BR
Oleksandr Shamray
\
 
 \ /
  Last update: 2017-12-01 12:12    [W:0.120 / U:1.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site