Messages in this thread Patch in this message |  | | Date | Wed, 8 Nov 2017 20:54:51 -0800 (PST) | From | Zhenzhong Duan <> | Subject | [PATCH] tick/broadcast: Remove redundant code in tick_check_new_device() |
| |
There is no way a timer used as broadcast clockevent device is also used as percpu tick clockevent device currently.
It's better to put related code in tick_install_broadcast_device(), but I feel it's harmless to give it back to the clockevents layer. Pls correct me if I'm wrong.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com> --- kernel/time/tick-common.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 49edc1c..9bcc866 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -320,13 +320,8 @@ void tick_check_new_device(struct clock_event_device *newdev) /* * Replace the eventually existing device by the new - * device. If the current device is the broadcast device, do - * not give it back to the clockevents layer ! + * device. */ - if (tick_is_broadcast_device(curdev)) { - clockevents_shutdown(curdev); - curdev = NULL; - } clockevents_exchange_device(curdev, newdev); tick_setup_device(td, newdev, cpu, cpumask_of(cpu)); if (newdev->features & CLOCK_EVT_FEAT_ONESHOT) -- 1.7.3
|  |