lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Part2 PATCH v7 20/38] crypto: ccp: Implement SEV_PDH_CERT_EXPORT ioctl command
From
Date


On 11/05/2017 05:34 AM, Borislav Petkov wrote:
...

>
> Fixes ontop:
>
> * !input.cert_chain_address test was repeated. I saw that by aligning
> them vertically, i.e., after making it more readable, the repetition
> became obvious.
>
> * Do the lengths checks first and the access_ok after, in each PDH and
> cert chain test.
>
> * Do the checks first and the allocations after, not interleaved.
>
> * Comments are sentences which should end with a '.'
>
> (hunk below contains also that &psp_master->cmd_buf change but you're going to
> remove that arg anyway).
>


I am good with all your fixup, I will apply them in v8.

-Brijesh

\
 
 \ /
  Last update: 2017-11-06 17:17    [W:0.093 / U:3.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site