lkml.org 
[lkml]   [2017]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver
Date
Thnaks for point 

Best Regards,
Oleksandr Shamray

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@nexb.com]
> Sent: Thursday, November 30, 2017 10:21 AM
> To: Kun Yi <kunyi@google.com>
> Cc: Oleksandr Shamray <oleksandrs@mellanox.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; arnd@arndb.de; system-sw-low-level <system-
> sw-low-level@mellanox.com>; devicetree@vger.kernel.org; jiri@resnulli.us;
> Vadim Pasternak <vadimp@mellanox.com>; linux-api@vger.kernel.org;
> OpenBMC Maillist <openbmc@lists.ozlabs.org>; LKML <linux-
> kernel@vger.kernel.org>; openocd-devel-owner@lists.sourceforge.net;
> mec@shout.net; Jiri Pirko <jiri@mellanox.com>; robh+dt@kernel.org; linux-
> serial@vger.kernel.org; tklauser@distanz.ch; Mauro Carvalho Chehab
> <mchehab@kernel.org>; David S. Miller <davem@davemloft.net>; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx
> families JTAG master driver
>
> On Wed, Nov 29, 2017 at 11:51 PM, Kun Yi <kunyi@google.com> wrote:
> > On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray
> > <oleksandrs@mellanox.com> wrote:
> []
> >> diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c
> >> new file mode 100644 index 0000000..a6e2417
> >> --- /dev/null
> >> +++ b/drivers/jtag/jtag-aspeed.c
> >> @@ -0,0 +1,782 @@
> >> +/*
> >> + * drivers/jtag/aspeed-jtag.c
> >> + *
> >> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.
> >> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs@mellanox.com>
> >> + *
> >> + * Released under the GPLv2 only.
> >> + * SPDX-License-Identifier: GPL-2.0
> >> + */
>
> I think the SPDX id should be on the first line as requested by Linus and
> documented by Thomas (tglx) and Greg (greg-kh). And it should use //
> comments, e.g:
>
> // SPDX-License-Identifier: GPL-2.0
>
> See the threads discussing all these.
>
>
> --
> Cordially
> Philippe Ombredanne
\
 
 \ /
  Last update: 2017-11-30 11:50    [W:0.065 / U:1.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site