lkml.org 
[lkml]   [2017]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] nvme: fix eui_show() print format
From
Date
On Fri, 2017-11-03 at 13:55 +0100, Christoph Hellwig wrote:
> On Fri, Nov 03, 2017 at 11:02:50AM +0100, Javier González wrote:
> > Signed-off-by: Javier González <javier@cnexlabs.com>
[]
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
[]
> > @@ -2108,7 +2108,7 @@ static ssize_t eui_show(struct device *dev, struct device_attribute *attr,
> > char *buf)
> > {
> > struct nvme_ns *ns = nvme_get_ns_from_dev(dev);
> > - return sprintf(buf, "%8phd\n", ns->eui);
> > + return sprintf(buf, "%8phD\n", ns->eui);
> > }
> > static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL);
>
> This looks correct. I wonder what the old code printed - does someone
> have a device with an EUI-64 at hand to quickly cross check what we
> did before?

It uses spaces between bytes and not dashes.

The code has been this way a couple years now.

I think this proposal, while it might fix an
unintentional output style, could also be an API
and could cause user breakage if changed.

Perhaps this should just become

%8ph

without D


\
 
 \ /
  Last update: 2017-11-03 16:17    [W:0.113 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site