lkml.org 
[lkml]   [2017]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] nvme: compare NQN string with right size
On Fri, Nov 03, 2017 at 11:02:49AM +0100, Javier González wrote:
> Compare subnqns using NVMF_NQN_SIZE as it is < 256
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index bd1d5ff911c9..ae8ab0a1ef0d 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1743,7 +1743,7 @@ static void nvme_init_subnqn(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id)
>
> nqnlen = strnlen(id->subnqn, NVMF_NQN_SIZE);
> if (nqnlen > 0 && nqnlen < NVMF_NQN_SIZE) {
> - strcpy(ctrl->subnqn, id->subnqn);
> + strncpy(ctrl->subnqn, id->subnqn, NVMF_NQN_SIZE);
> return;
> }

This isn't a compare, but a copy. Except for that it looks ok to me.

\
 
 \ /
  Last update: 2017-11-03 13:55    [W:0.130 / U:6.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site