[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling
On Wed, 27 Sep 2017, Shawn Nematbakhsh wrote:

> For host commands that take a long time to process, cros ec can return
> early by signaling a EC_RES_IN_PROGRESS result. The host must then poll
> status with EC_CMD_GET_COMMS_STATUS until completion of the command.
> None of the above applies when data link errors are encountered. When
> errors such as EC_SPI_PAST_END are encountered during command
> transmission, it usually means the command was not received by the EC.
> Treating such errors as if they were 'EC_RES_IN_PROGRESS' results is
> almost always the wrong decision, and can result in host commands
> silently being lost.
> Reported-and-tested-by: Jon Hunter <>
> Signed-off-by: Shawn Nematbakhsh <>
> ---
> drivers/mfd/cros_ec_spi.c | 52 ++++++++++++++++++++++-------------------------
> 1 file changed, 24 insertions(+), 28 deletions(-)

Applied, thanks.

Lee Jones
Linaro STMicroelectronics Landing Team Lead │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

 \ /
  Last update: 2017-11-29 13:12    [W:0.141 / U:3.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site