lkml.org 
[lkml]   [2017]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/14] soundwire: Add SoundWire bus type
On Thu, Nov 16, 2017 at 10:32:21PM +0530, Vinod Koul wrote:
> On Thu, Nov 16, 2017 at 04:05:17PM +0000, Srinivas Kandagatla wrote:

> > >+static const struct sdw_device_id *
> > >+sdw_get_device_id(struct sdw_slave *slave, struct sdw_driver *drv)
> > Indentation looks Odd here,

> not really, the return type in preceding line is a perfect way to define
> things...

Yeah, that's fairly normal - just ugly long. You could also do it by
splitting the arguments over two lines.

> > >+ ret = dev_pm_domain_attach(dev, false);
> > >+ if (ret) {

> > I think we discussed this in v1, but erring out here means that all the
> > devices need to have pm domain attached, which might not be true all the
> > time.

> oh yes, sorry i missed this one. will fix

Looking at this pattern here I'm wondering if this should be folded into
the domain code, everything attaching a domain is going to need to take
care of this at the minute.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-11-17 17:18    [W:0.060 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site