Messages in this thread Patch in this message |  | | From | Geert Uytterhoeven <> | Subject | [PATCH/RFC] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo() | Date | Thu, 16 Nov 2017 11:26:04 +0100 |
| |
With gcc-4.1.2:
drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’: drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used uninitialized in this function
Indeed, if nl_client is not found in any of the scanned has buckets, ret will be used uninitialized.
Preinitialize ret to zero to fix this.
Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper user space service") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- RFC as I have no idea if this can ever happen, and if yes, what's the correct behavior to handle it: - return 0, - return an error code, - don't send anything, - anything else? --- drivers/infiniband/core/iwpm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c index 3c4faadb8cddd7fd..eb000b540495acd1 100644 --- a/drivers/infiniband/core/iwpm_util.c +++ b/drivers/infiniband/core/iwpm_util.c @@ -644,7 +644,7 @@ int iwpm_send_mapinfo(u8 nl_client, int iwpm_pid) int i = 0, nlmsg_bytes = 0; unsigned long flags; const char *err_str = ""; - int ret; + int ret = 0; skb = dev_alloc_skb(NLMSG_GOODSIZE); if (!skb) { -- 2.7.4
|  |