lkml.org 
[lkml]   [2017]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4.4 06/56] dt-bindings: clockgen: Add compatible string for LS1012A
On Wed, Nov 15, 2017 at 03:25:04PM +0000, Bhaskar Upadhaya wrote:
>
>
> -----Original Message-----
> From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, November 15, 2017 8:46 PM
> To: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Harninder Rai <harninder.rai@nxp.com>; Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; Rob Herring <robh@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sasha Levin <alexander.levin@verizon.com>
> Subject: Re: [PATCH 4.4 06/56] dt-bindings: clockgen: Add compatible string for LS1012A
>
> On Tue, Nov 14, 2017 at 03:46:10PM +0000, Ben Hutchings wrote:
> > On Mon, 2017-11-13 at 13:55 +0100, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let
> > > me know.
> > >
> > > ------------------
> > >
> > > From: Harninder Rai <harninder.rai@nxp.com>
> > >
> > >
> > > [ Upstream commit 73447f68d7b2bc1df870da88b0e21d2bc1afc025 ]
> > >
> > > Signed-off-by: Harninder Rai <harninder.rai@nxp.com>
> > > Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > >  Documentation/devicetree/bindings/clock/qoriq-clock.txt |    1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > @@ -31,6 +31,7 @@ Required properties:
> > >   * "fsl,t4240-clockgen"
> > >   * "fsl,b4420-clockgen"
> > >   * "fsl,b4860-clockgen"
> > > + * "fsl,ls1012a-clockgen"
> >
> > This isn't supported or used anywhere in 4.4, so it makes sense to
> > document it.
>
> It "does" or "does not" make sense? Should I drop this patch?
> [Bhaskar]
> Hi Greg,
> "fsl,ls1012a-clockgen" is getting used in the file drivers/clk/clk-qoriq.c(kernel v4.14) as below.
> {
> .compat = "fsl,ls1012a-clockgen",
> .cmux_groups = {
> &ls1012a_cmux
> },
> .cmux_to_group = {
> 0, -1
> },
> .pll_mask = 0x03,
> },

4.14 is great, but this is the 4.4-stable queue :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-11-15 16:53    [W:0.125 / U:1.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site