[lkml]   [2017]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/1] Use to make thinkpad_acpi.c error free: octal permissions
On Wed, Nov 15, 2017 at 1:14 AM, Simranjit Singh
<> wrote:
> From: Simranjit Singh <>
> Using the script, there were 8 errors in thinkpad_acpi.c. I fixed them by changing permissions to octal,
> and by adding parenthesis.
> On the current tree, if you use, thinkpad_acpi.c will have 8 errors. With my changes, there are 0 errors.
> However, I have added 3 new warnings.
> I'm very new to kernel development, so if I messed up somewhere, please do tell me.
> Changed binary permissions to octal in accordance with in thinkpad_acpi.c

Besides comments you got already, keep in mind that patch numbering
starts from 1, 0 is a special dedicated value for cover letter which
you apparently miss.
Of course, in case of this "series" you are not supposed to make it as a series.

And one more time, it's a contributor's responsibility to test (*)
changes before sending _by default _.

*) sometimes compilation test is enough, though most of the times the
real run would be required.

As per change 0 to 0444 for the cases you did, you obviously didn't
read the code and thus may not understand the ABI of this module.

So, obvious NAK for this patch.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2017-11-15 12:03    [W:0.032 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site