[lkml]   [2017]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH AUTOSEL for 4.9 44/56] ASoC: dwc: Fix PIO mode initialization
On Wed, Nov 15, 2017 at 02:45:45AM +0000, wrote:

> We can no longer rely on the return value of
> devm_snd_dmaengine_pcm_register(...) to check if the DMA
> handle is declared in the DT.

> Previously this check activated PIO mode but currently
> dma_request_chan returns either a valid channel or -EPROBE_DEFER.

So when did the corresponding change to the dmaengine API go in?

> In order to activate PIO mode check instead if the interrupt
> line is declared. This reflects better what is documented in
> the DT bindings (see Documentation/devicetree/bindings/sound/
> designware-i2s.txt).

> Also, initialize use_pio variable which was never being set
> causing PIO mode to never work.

Though if PIO mode never worked presumably this isn't that urgent...
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2017-11-15 11:55    [W:0.299 / U:7.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site