lkml.org 
[lkml]   [2017]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC 7/7] x86/unwind/64: Add support for the SYSENTER stack
On Mon, Nov 13, 2017 at 2:46 PM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Fri, Nov 10, 2017 at 08:05:26PM -0800, Andy Lutomirski wrote:
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> I would make the subject more specific and less unwinder-centric, like:
>
> "x86/dumpstack: Add get_stack_info() support for the SYSENTER stack"
>
> since there aren't yet any changes to the unwinders themselves (which
> I'm assuming will be needed once you start using the stack).
>
> Also, at least a one-sentence description would be good.
>
> Otherwise the patch looks good to me.

Done. I also added 32-bit support.

>
> --
> Josh

\
 
 \ /
  Last update: 2017-11-14 03:14    [W:0.059 / U:4.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site