lkml.org 
[lkml]   [2017]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck


On Thu, 9 Nov 2017, Masahiro Yamada wrote:

> The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of
> "coccicheck failed" error messages.
>
> I do not know the coccinelle internals, but I guess --jobs does not
> work well if spatch is invoked from Make running in parallel.
> Disable --jobs in this case.

Why is this change under:

if [ "$C" = "1" -o "$C" = "2" ];

The coccicheck failed messages come also if one runs Coccinelle on the
entire kernel.

julia


>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Grep '-j' instead of '--jobserver-auth'.
> '--jobserver-*' is not a stable option flag.
> Make 4.2 change '--jobserver-fds' into '--jobserver-auth'
> - Add -q option to grep
>
> scripts/coccicheck | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 040a8b1..8bab11e 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -70,6 +70,9 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
> # Take only the last argument, which is the C file to test
> shift $(( $# - 1 ))
> OPTIONS="$COCCIINCLUDE $1"
> +
> + # --jobs does not work if Make is running in parallel
> + echo $MAKEFLAGS | grep -q -E '(^| )-j' && USE_JOBS="no"
> else
> ONLINE=0
> if [ "$KBUILD_EXTMOD" = "" ] ; then
> --
> 2.7.4
>
>

\
 
 \ /
  Last update: 2017-11-13 16:31    [W:0.068 / U:2.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site