[lkml]   [2017]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.4 45/56] selftests: firmware: add empty string and async tests
4.4-stable review patch.  If anyone has any objections, please let me know.


From: Brian Norris <>

commit 1b1fe542b6f010cf6bc7e1c92805e1c0e133e007 upstream.

Now that we've added a 'trigger_async_request' knob to test the
request_firmware_nowait() API, let's use it. Also add tests for the
empty ("") string, since there have been a couple errors in that
handling already.

Since we now have real ways that the sysfs write might fail, let's add
the appropriate check on the 'echo' lines too.

Signed-off-by: Brian Norris <>
Acked-by: Kees Cook <>
Signed-off-by: Shuah Khan <>
[AmitP: Dropped the async trigger testing parts from original commit]
Signed-off-by: Amit Pundir <>
Signed-off-by: Greg Kroah-Hartman <>
tools/testing/selftests/firmware/ | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

--- a/tools/testing/selftests/firmware/
+++ b/tools/testing/selftests/firmware/
@@ -48,8 +48,16 @@ echo "ABCD0123" >"$FW"

NAME=$(basename "$FW")

+if printf '\000' >"$DIR"/trigger_request; then
+ echo "$0: empty filename should not succeed" >&2
+ exit 1
# Request a firmware that doesn't exist, it should fail.
-echo -n "nope-$NAME" >"$DIR"/trigger_request
+if echo -n "nope-$NAME" >"$DIR"/trigger_request; then
+ echo "$0: firmware shouldn't have loaded" >&2
+ exit 1
if diff -q "$FW" /dev/test_firmware >/dev/null ; then
echo "$0: firmware was not expected to match" >&2
exit 1

 \ /
  Last update: 2017-11-13 13:59    [W:0.223 / U:11.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site