[lkml]   [2017]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V13 06/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK
On Thu, Nov 9, 2017 at 8:12 AM, Adrian Hunter <> wrote:
> On 08/11/17 11:24, Linus Walleij wrote:
>> On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter <> wrote:
>>> Add CQHCI initialization and implement CQHCI operations for Intel GLK.
>>> Signed-off-by: Adrian Hunter <>
>> This patch seems OK in context, but it merely illustrates the
>> weirdness of .[runtime]_suspend/resume calling into CQE-specific
>> APIs rather than using generic host callbacks.
> Your comment makes no sense at all. The host driver has
> [runtime]_suspend/resume callbacks and it is up to the host driver to decide
> what to do. CQHCI provides helpers since that is the whole point of having
> a CQHCI library.

Yeah I didn't see it in context, the CQHCI library for these hosts
make a lot of sense.

Linus Walleij

 \ /
  Last update: 2017-11-10 09:18    [W:0.085 / U:3.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site