lkml.org 
[lkml]   [2017]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/6] dt-bindings: fsi: Add SBEFIFO documentation
On Fri, Sep 22, 2017 at 04:05:57PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>
>
> Document the bindings for the SBE CFAM device. SBE devices are
> located on a CFAM off an FSI bus.
>
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
> .../devicetree/bindings/fsi/ibm,p9-sbefifo.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
>
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> new file mode 100644
> index 0000000..07fbf29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> @@ -0,0 +1,20 @@
> +Device-tree bindings for P9 SBEFIFO CFAM device
> +-----------------------------------------------
> +
> +Required properties:
> + - reg = < address size > : FSI CFAM address for the SBE engine
> + and address space size.

compatible?

> +
> +Optional properties:
> + - <child nodes> : Devices that are accessible through
> + the SBEFIFO.

You need some sort of definition what's in the child nodes.

> +
> +Examples:
> +
> + sbefifo@2400 {
> + reg = < 0x2400 0x400 >;

Need #{address,size}-cells here.

> +
> + occ@1 {

Need a reg property here and you need to define what reg represents.

> + ...
> + };
> + };
> --
> 1.8.3.1
>

\
 
 \ /
  Last update: 2017-10-04 22:58    [W:0.088 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site